linux-kernel - Re: [PATCH] staging: lustre: lnet: lnet: Added a space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Sep 2015 17:15:30 -0400
From:	Trevor Woerner <twoerner@...il.com>
To:	Anjali Menon <cse.anjalimenon@...il.com>,
	gregkh@...uxfoundation.org
Cc:	devel@...verdev.osuosl.org, andreas.dilger@...el.com,
	kp.balavasu@...il.com, linux-kernel@...r.kernel.org,
	oleg.drokin@...el.com, joe@...ches.com
Subject: Re: [PATCH] staging: lustre: lnet: lnet: Added a space

On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:

Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?

> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@...il.com>
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
> index 8510bae..be23e06 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
>  	unsigned long		now = cfs_time_current();
>  	int			cpt = lnet_cpt_of_nid(nid);
>  
> -	LASSERT(!in_interrupt ());
> +	LASSERT(!in_interrupt());
>  
>  	CDEBUG(D_NET, "%s notifying %s: %s\n",
>  		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/