linux-kernel - Re: [PATCH 1/5 v2] mm/memblock: Introduce memblock_first_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150915163248.d7a5e3fdb4e4dfa344731624@linux-foundation.org>
Date:	Tue, 15 Sep 2015 16:32:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Tony Luck <tony.luck@...el.com>, Pekka Enberg <penberg@...nel.org>,
	Mel Gorman <mgorman@...e.de>, Xishi Qiu <qiuxishi@...wei.com>,
	Robin Holt <holt@....com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5 v2] mm/memblock: Introduce
 memblock_first_region_size() helper

On Tue,  1 Sep 2015 20:27:11 +0600 Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> Some architectures (like s390, microblaze and etc...) require size
> of the first memory region. This patch provides new memblock_first_region_size()
> helper for this case.
> 
> ...
>
> +phys_addr_t __init_memblock memblock_first_region_size(void)
> +{
> +	return memblock.memory.regions[0].size;
> +}
> +

Some callers call this from __init code, which is OK.

Other callers call it from an inlined function and I'm too lazy to work
out if all the callers of those callers are calling
memblock_first_region_size() from a compatible section.

So please either a) demonstrate that all the sectioning is correct (and
maintainable!) or b) simply inline memblock_first_region_size()...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/