linux-kernel - Re: [PATCH 09/39] aoe: drop null test before destroy functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F776B5.2090203@acm.org>
Date:	Mon, 14 Sep 2015 21:39:01 -0400
From:	Ed Cashin <ed.cashin@....org>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	sergey.senozhatsky@...il.com, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/39] aoe: drop null test before destroy functions

ACK.  Thanks.

On 09/13/2015 08:15 AM, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
>    \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
>   drivers/block/aoe/aoedev.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
> index ffd1947..efc8a8a 100644
> --- a/drivers/block/aoe/aoedev.c
> +++ b/drivers/block/aoe/aoedev.c
> @@ -285,8 +285,7 @@ freedev(struct aoedev *d)
>   	e = t + d->ntargets;
>   	for (; t < e && *t; t++)
>   		freetgt(d, *t);
> -	if (d->bufpool)
> -		mempool_destroy(d->bufpool);
> +	mempool_destroy(d->bufpool);
>   	skbpoolfree(d);
>   	minor_free(d->sysminor);
>   
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/