linux-kernel - Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1442308254.3979.31.camel@pengutronix.de>
Date:	Tue, 15 Sep 2015 11:10:54 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	pawel.moll@....com, xuwei5@...ilicon.com,
	haojian.zhuang@...aro.org, zhangfei.gao@...mail.com, arnd@...db.de,
	bintian.wang@...wei.com, xuyiping@...ilicon.com,
	devicetree@...r.kernel.org, dan.zhao@...ilicon.com,
	suzhuangluan@...ilicon.com, w.f@...wei.com
Subject: Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon
 Hi6220 SoC

Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng:
> Add reset controller for hi6220 hikey-board.
> 
> Signed-off-by: Chen Feng <puck.chen@...ilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 3f03380..3bbc846 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -167,5 +167,12 @@
>  			clocks = <&ao_ctrl 36>, <&ao_ctrl 36>;
>  			clock-names = "uartclk", "apb_pclk";
>  		};
> +
> +		reset_ctrl: reset_ctrl@...30000 {
> +			compatible = "hisilicon,hi6220_reset_ctl";

Check out the other compatible strings that already are in the same dtsi
file, those use hyphens instead of underscores in their compatible
values. So for consistency, this should be:

+			compatible = "hisilicon,hi6220-reset-ctl";

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/