linux-kernel - Re: [PATCH v1 0/3] lib/string: introduce match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2015 11:35:29 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Airlie <airlied@...ux.ie>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v1 0/3] lib/string: introduce match_string() helper

Hello,

On Tue, Sep 15, 2015 at 09:53:48AM +0300, Andy Shevchenko wrote:
> There are users of a simple string matching in the array. Let's do a common
> helper for that.
> 
> Two users are updated in the series. one more is coming [1].
> 
> [1] http://www.spinics.net/lists/kernel/msg2074265.html
> 
> The series is compile tested.
> 
> Andy Shevchenko (3):
>   lib/string: introduce match_string() helper
>   drm/edid: convert to use match_string() helper
>   ata: hpt366: convert to use match_string() helper
> 
>  drivers/ata/pata_hpt366.c       | 13 +++++--------
>  drivers/gpu/drm/drm_edid_load.c | 17 ++++++-----------
>  include/linux/string.h          |  7 +++++++
>  lib/string.c                    | 26 ++++++++++++++++++++++++++
>  4 files changed, 44 insertions(+), 19 deletions(-)

While increase in LOC isn't the only indicator, we're adding two
helper functions each for two usages.  I'm not quite sure the addition
of helpers is paying off here.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/