linux-kernel - Re: [PATCH] pptp: avoid releasing the sock too early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55F857BE.6060201@oracle.com>
Date:	Tue, 15 Sep 2015 13:39:10 -0400
From:	Sasha Levin <sasha.levin@...cle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	xeb@...l.ru, ebiederm@...ssion.com, davem@...emloft.net,
	simon@...nz.org.uk, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pptp: avoid releasing the sock too early

On 09/14/2015 12:43 PM, Eric Dumazet wrote:
> Hmm, is the synchronize_rcu() in del_chan() still needed, and why it was
> not enough ?
> 
> I believe your patch might reduce the race window, but it is not clear
> it is the right fix.

You're right, I've missed the synchronize_rcu() originally. At this point
I'm certain that my patch is incorrect (so ignore it please), but I don't see
the cause of the bug either.

Let me think about it some more...


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/