[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <77103FCE-5756-45AF-B764-310E51097781@martin.sperl.org>
Date: Wed, 16 Sep 2015 07:25:51 +0200
From: Martin Sperl <kernel@...tin.sperl.org>
To: Stephen Warren <swarren@...dotorg.org>
Cc: Lee Jones <lee@...nel.org>, Russell King <linux@....linux.org.uk>,
Mark Brown <broonie@...nel.org>,
Mark Rutland <mark.rutland@....com>,
devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-spi@...r.kernel.org,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux
> On 16.09.2015, at 06:12, Stephen Warren <swarren@...dotorg.org> wrote:
>
> On 09/04/2015 01:26 AM, Martin Sperl wrote:
>>
>>> On 26.08.2015, at 03:44, Stephen Warren <swarren@...dotorg.org> wrote:
>>>
>>> On 08/24/2015 02:40 AM, kernel@...tin.sperl.org wrote:
>>>
>>>> +Example:
>>>> +
>>>> +aux_enable: aux_enable@...e215004 {
>>>> + compatible = "bcrm,bcm2835-aux";
>>>> + reg = <0x7e215004 0x04>;
>>>
>>> I'd expect that to be <0x7e215000 0x8>;
>>
>> The reason is that we just handle enable with this driver,
>> which just requires access to the 0x7e215004 register.
>>
>> The 0x7e215000 register (interrupt mask) could be used by a
>> cascaded interrupt-controller, but as the spi and uart drivers
>> can run with shared interrupts this is not a necessity.
>
> The DT is supposed to describe the HW, not any particular SW's use of
> the HW. If the HW block has 2 registers, so must the DT reg property.
Please look at V6 of the patch-series, that uses Erics clock-patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists