linux-kernel - Re: [PATCH 13/31] memstick: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Sep 2015 11:57:41 +0200
From:	Andrzej Hajda <a.hajda@...sung.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/31] memstick: use kmemdup rather than duplicating its
 implementation

Ping.

Regards
Andrzej


On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  drivers/memstick/core/mspro_block.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index 922a750..1f1dd9b 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card)
>  	}
>  	msb->attr_group.name = "media_attributes";
>  
> -	buffer = kmalloc(attr_len, GFP_KERNEL);
> +	buffer = kmemdup((char *)attr, attr_len, GFP_KERNEL);
>  	if (!buffer) {
>  		rc = -ENOMEM;
>  		goto out_free_attr;
>  	}
> -	memcpy(buffer, (char *)attr, attr_len);
>  
>  	for (cnt = 0; cnt < attr_count; ++cnt) {
>  		s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/