linux-kernel - Re: [PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <55F93E3F.20604@samsung.com>
Date:	Wed, 16 Sep 2015 12:02:39 +0200
From:	Andrzej Hajda <a.hajda@...sung.com>
To:	Adaptec OEM Raid Solutions <aacraid@...ptec.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating
 its implementation

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  drivers/scsi/aacraid/commctrl.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
> index 54195a1..d2ed626 100644
> --- a/drivers/scsi/aacraid/commctrl.c
> +++ b/drivers/scsi/aacraid/commctrl.c
> @@ -635,15 +635,14 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
>  			}
>  		} else {
>  			struct user_sgmap* usg;
> -			usg = kmalloc(actual_fibsize - sizeof(struct aac_srb)
> -			  + sizeof(struct sgmap), GFP_KERNEL);
> +			usg = kmemdup(upsg,
> +				      actual_fibsize - sizeof(struct aac_srb) + sizeof(struct sgmap),
> +				      GFP_KERNEL);
>  			if (!usg) {
>  				dprintk((KERN_DEBUG"aacraid: Allocation error in Raw SRB command\n"));
>  				rcode = -ENOMEM;
>  				goto cleanup;
>  			}
> -			memcpy (usg, upsg, actual_fibsize - sizeof(struct aac_srb)
> -			  + sizeof(struct sgmap));
>  			actual_fibsize = actual_fibsize64;
>  
>  			for (i = 0; i < usg->count; i++) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/