linux-kernel - Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <55F93EF7.60405@samsung.com>
Date:	Wed, 16 Sep 2015 12:05:43 +0200
From:	Andrzej Hajda <a.hajda@...sung.com>
To:	Bob Copeland <me@...copeland.com>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org,
	linux-karma-devel@...ts.sourceforge.net
Subject: Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its
 implementation

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  fs/omfs/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
> index 3d935c8..02af1a3 100644
> --- a/fs/omfs/inode.c
> +++ b/fs/omfs/inode.c
> @@ -333,12 +333,11 @@ static int omfs_get_imap(struct super_block *sb)
>  		bh = sb_bread(sb, block++);
>  		if (!bh)
>  			goto nomem_free;
> -		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
> +		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
>  		if (!*ptr) {
>  			brelse(bh);
>  			goto nomem_free;
>  		}
> -		memcpy(*ptr, bh->b_data, sb->s_blocksize);
>  		if (count < sb->s_blocksize)
>  			memset((void *)*ptr + count, 0xff,
>  				sb->s_blocksize - count);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/