linux-kernel - Re: [PATCH] KVM: vmx: fix VPID is 0000H in non-root operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLU436-SMTP108B8E50BECEB570CADFB81805B0@phx.gbl>
Date:	Wed, 16 Sep 2015 21:53:35 +0800
From:	Wanpeng Li <wanpeng.li@...mail.com>
To:	Paolo Bonzini <pbonzini@...hat.com>,
	Jan Kiszka <jan.kiszka@...mens.com>
CC:	Bandan Das <bsd@...hat.com>, Wincy Van <fanwenyi0529@...il.com>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: vmx: fix VPID is 0000H in non-root operation

On 9/16/15 8:42 PM, Paolo Bonzini wrote:
>
> On 16/09/2015 14:32, Jan Kiszka wrote:
>> BTW, what will happen if allocate_vpid runs out of free slots and
>> returns 0? Will we always fail then...?
> The return value of vmx_secondary_exec_control will not have
> SECONDARY_EXEC_ENABLE_VPID, so it's okay.  However, I think
> we need this in the nested VPID patches:
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c23482cda1a7..e6859b45b00b 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -9456,7 +9460,7 @@ static void prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12)
>   	else
>   		vmcs_write64(TSC_OFFSET, vmx->nested.vmcs01_tsc_offset);
>
> -	if (enable_vpid) {
> +	if (vmx->nested.vpid02) {
>   		/*
>   		 * There is no direct mapping between vpid02 and vpid12, the
>   		 * vpid02 is per-vCPU for L0 and reused while the value of
>

Looks good to me.

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/