linux-kernel - Re: [PATCH] scsi: provide UAPI version of scsi/sg.h and scsi/scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55F97992.6050905@redhat.com>
Date:	Wed, 16 Sep 2015 16:15:46 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Christoph Hellwig <hch@....de>
Cc:	linux-kernel@...r.kernel.org, houcheng@...il.com,
	Andy Grover <agrover@...hat.com>,
	James Bottomley <jbottomley@...allels.com>,
	Douglas Gilbert <dgilbert@...erlog.com>,
	Linux SCSI List <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] scsi: provide UAPI version of scsi/sg.h and
 scsi/scsi_ioctl.h

On 16/09/2015 15:39, Christoph Hellwig wrote:
> Hi Paolo,
> 
> can you just move them to include/linux/ directly?

I'm trying to cater to the objections that were made to Andy's patch.
If you mean the non-UAPI headers, James wanted them to stay in scsi/; if
you mean the UAPI headers, Douglas complained about the flat structure
of include/linux/.

> Also scsi/scsi.h has some additional ioctl defintions that should be
> added to the UAPI scsi_ioctl.h.  Otherwise this looks ok to me.

I can do this, but I think they are obsoleted by SG_GET_SCSI_ID, except
for SCSI_IOCTL_GET_PCI which is horrible anyway. :)  The comment about
conflicts with CDROM ioctls is also interesting.  I can see why one
would want to keep them out of the new canonical place for SCSI ioctls.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/