linux-kernel - Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation

Open Source and information security mailing list archives

Date:	Wed, 16 Sep 2015 18:21:34 +0200
From:	Christian König <deathsimple@...afone.de>
To:	Andrzej Hajda <a.hajda@...sung.com>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	David Airlie <airlied@...ux.ie>
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its
 implementation

On 16.09.2015 11:56, Andrzej Hajda wrote:
> Ping.
>
> Regards
> Andrzej
>
> On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
>> The patch was generated using fixed coccinelle semantic patch
>> scripts/coccinelle/api/memdup.cocci [1].
>>
>> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>

Somehow missed that. Patch is Reviewed-by: Christian König 
<christian.koenig@....com>.

Regards,
Christian.

>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 8da6424..94bd992 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata,
>>   	if (metadata == NULL)
>>   		return -EINVAL;
>>   
>> -	buffer = kzalloc(metadata_size, GFP_KERNEL);
>> +	buffer = kmemdup(metadata, metadata_size, GFP_KERNEL);
>>   	if (buffer == NULL)
>>   		return -ENOMEM;
>>   
>> -	memcpy(buffer, metadata, metadata_size);
>> -
>>   	kfree(bo->metadata);
>>   	bo->metadata_flags = flags;
>>   	bo->metadata = buffer;
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives