linux-kernel - Re: [PATCH 1/3] regmap: irq: add support for chips who have separate unmask registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150916193720.GP12027@sirena.org.uk>
Date:	Wed, 16 Sep 2015 20:37:20 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Barry Song <21cnbao@...il.com>
Cc:	gregkh@...uxfoundation.org, sameo@...ux.intel.com,
	lee.jones@...aro.org, linux-kernel@...r.kernel.org,
	workgroup.linux@....com, Guo Zeng <Guo.Zeng@....com>,
	Barry Song <Baohua.Song@....com>
Subject: Re: [PATCH 1/3] regmap: irq: add support for chips who have separate
 unmask registers

On Mon, Sep 14, 2015 at 09:40:08AM +0000, Barry Song wrote:

> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -800,12 +800,15 @@ struct regmap_irq {
>   *
>   * @status_base: Base status register address.
>   * @mask_base:   Base mask register address.
> + * @unmask_base:  Base unmask register address. for chips who have
> + *                separate mask and unmask registers
>   * @ack_base:    Base ack address. If zero then the chip is clear on read.
>   *               Using zero value is possible with @use_ack bit.
>   * @wake_base:   Base address for wake enables.  If zero unsupported.
>   * @irq_reg_stride:  Stride to use for chips where registers are not contiguous.
>   * @init_ack_masked: Ack all masked interrupts once during initalization.
>   * @mask_invert: Inverted mask register: cleared bits are masked out.
> + * @unmask_separate: unmask is separate register from mask.

We shouldn't need this - we should just be able to check if there's an
unmask_base set and use that.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)