linux-kernel - Re: [PATCH V2] dummy_hcd: replace timeval with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Sep 2015 10:12:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	WEN Pingbo <pingbo.wen@...aro.org>
Cc:	linux-usb@...r.kernel.org, Y2038 <y2038@...ts.linaro.org>,
	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64

On Thursday 17 September 2015 11:09:49 WEN Pingbo wrote:
> The millisecond of the last second will be normal if tv_sec is
> overflowed. But for y2038 consistency and demonstration purpose,
> and avoiding further risks, we need to remove 'timeval' in this
> driver, to avoid similair problems.
> 
> V2 Updates:
> - using monotonic time here by replacing getnstimeofday() with
>   ktime_get_ts64(), to avoid leap second issues. The frame time in USB
>   is always 1ms, no matter what speed, so ktime_get_ts64() have enough
>   resolution to cover this.
> - using NSEC_PER_MSEC instead of hard code.
> 
> Signed-off-by: Pingbo Wen <pingbo.wen@...aro.org>
> Cc: Y2038 <y2038@...ts.linaro.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Felipe Balbi <balbi@...com>
> Signed-off-by: WEN Pingbo <pingbo.wen@...aro.org>
> 

The patch looks good to me now,

Reviewed-by: Arnd Bergmann <arnd@...db.de>

Regarding the changelog, I notice you have a duplicate Signed-off-by
line, one of the two should be removed. Also, The "V2 update" portion
should be split into the part that you want in the changelog, without
the '-' bullet points (in this case, the explanation for monontonic
time), and the purely informational part that makes sense for the
review but not for the git history (what changes were done against
previous versions of the patch), which should go below the '---'
line under the Signed-off-by chain, so it gets removed when imported
to git.

If Felipe decides to do these changes himself when he applies the
patch, that's fine, otherwise please send the patch again as 'V3'
tomorrow.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/