linux-kernel - Re: [PATCH] mmc: sdhci: call sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqvzcUO8k=7yZYfHd5S77f45cFCuTfLg6Sxs-1ntiC4BQ@mail.gmail.com>
Date:	Thu, 17 Sep 2015 10:48:56 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Haibo Chen <haibo.chen@...escale.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Ivan Ivanov <ivan.ivanov@...aro.org>,
	Scott Branden <sbranden@...adcom.com>,
	Vincent Yang <vincent.yang.fujitsu@...il.com>,
	Andrew Gabbasov <andrew_gabbasov@...tor.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci: call sdhci_init() before request irq

On 15 September 2015 at 12:32, Haibo Chen <haibo.chen@...escale.com> wrote:
> sdhci_init() will clear all irqs and set the needed irqs. So
> logically sdhci_init() should be called before request irq.
>
> If not, some irqs may be triggled and handled wrongly. Take
> the following into consideration, after request irq, if
> SDIO card interrupt enabled, a sd card in the sd slot will
> trigger a mass of interrupt(SDHCI_INT_CARD_INT), because at
> this time, the vmmc-regulator still not restore, no voltage
> supply for the sd card, so the pin of data0~data3 change and
> keep low, interrupt(SDHCI_INT_CARD_INT) will rise up ceaselessly.
> Due to we already reguest irq, system will be busy in handling
> this endless irq, can't response to other event.
>
> So we should call sdhci_init() before request irq in sd resume.
>
> Signed-off-by: Haibo Chen <haibo.chen@...escale.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 64b7fdb..6861573 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2714,17 +2714,6 @@ int sdhci_resume_host(struct sdhci_host *host)
>                         host->ops->enable_dma(host);
>         }
>
> -       if (!device_may_wakeup(mmc_dev(host->mmc))) {
> -               ret = request_threaded_irq(host->irq, sdhci_irq,
> -                                          sdhci_thread_irq, IRQF_SHARED,
> -                                          mmc_hostname(host->mmc), host);
> -               if (ret)
> -                       return ret;
> -       } else {
> -               sdhci_disable_irq_wakeups(host);
> -               disable_irq_wake(host->irq);
> -       }
> -
>         if ((host->mmc->pm_flags & MMC_PM_KEEP_POWER) &&
>             (host->quirks2 & SDHCI_QUIRK2_HOST_OFF_CARD_ON)) {
>                 /* Card keeps power but host controller does not */
> @@ -2737,6 +2726,17 @@ int sdhci_resume_host(struct sdhci_host *host)
>                 mmiowb();
>         }
>
> +       if (!device_may_wakeup(mmc_dev(host->mmc))) {
> +               ret = request_threaded_irq(host->irq, sdhci_irq,
> +                                          sdhci_thread_irq, IRQF_SHARED,
> +                                          mmc_hostname(host->mmc), host);
> +               if (ret)
> +                       return ret;
> +       } else {
> +               sdhci_disable_irq_wakeups(host);
> +               disable_irq_wake(host->irq);
> +       }
> +
>         sdhci_enable_card_detection(host);
>
>         return ret;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/