linux-kernel - Re: [PATCH 2/7] arm64: Shorten lines which exceed 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150917094533.GL25444@e104818-lin.cambridge.arm.com>
Date:	Thu, 17 Sep 2015 10:45:34 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Jeremy Linton <jeremy.linton@....com>
Cc:	linux-arm-kernel@...ts.infradead.org, steve.capper@....com,
	dwoods@...ip.com, linux-kernel@...r.kernel.org,
	will.deacon@....com, shijie.huang@....com
Subject: Re: [PATCH 2/7] arm64: Shorten lines which exceed 80 characters

On Wed, Sep 16, 2015 at 02:03:01PM -0500, Jeremy Linton wrote:
> PTE definitions in this file exceed 80 characters
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
> ---
>  arch/arm64/include/asm/pgtable-hwdef.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/pgtable-hwdef.h b/arch/arm64/include/asm/pgtable-hwdef.h
> index 24154b0..4489cf6 100644
> --- a/arch/arm64/include/asm/pgtable-hwdef.h
> +++ b/arch/arm64/include/asm/pgtable-hwdef.h
> @@ -99,14 +99,14 @@
>  #define PTE_TYPE_FAULT		(_AT(pteval_t, 0) << 0)
>  #define PTE_TYPE_PAGE		(_AT(pteval_t, 3) << 0)
>  #define PTE_TABLE_BIT		(_AT(pteval_t, 1) << 1)
> -#define PTE_USER		(_AT(pteval_t, 1) << 6)		/* AP[1] */
> -#define PTE_RDONLY		(_AT(pteval_t, 1) << 7)		/* AP[2] */
> -#define PTE_SHARED		(_AT(pteval_t, 3) << 8)		/* SH[1:0], inner shareable */
> -#define PTE_AF			(_AT(pteval_t, 1) << 10)	/* Access Flag */
> -#define PTE_NG			(_AT(pteval_t, 1) << 11)	/* nG */
> -#define PTE_DBM			(_AT(pteval_t, 1) << 51)	/* Dirty Bit Management */
> -#define PTE_PXN			(_AT(pteval_t, 1) << 53)	/* Privileged XN */
> -#define PTE_UXN			(_AT(pteval_t, 1) << 54)	/* User XN */
> +#define PTE_USER		(_AT(pteval_t, 1) << 6)  /* AP[1] */
> +#define PTE_RDONLY		(_AT(pteval_t, 1) << 7)  /* AP[2] */
> +#define PTE_SHARED		(_AT(pteval_t, 3) << 8)  /* inner shareable */
> +#define PTE_AF			(_AT(pteval_t, 1) << 10) /* Access Flag */
> +#define PTE_NG			(_AT(pteval_t, 1) << 11) /* nG */
> +#define PTE_DBM			(_AT(pteval_t, 1) << 51) /* Dirty Bit Mgmt */
> +#define PTE_PXN			(_AT(pteval_t, 1) << 53) /* Privileged XN */
> +#define PTE_UXN			(_AT(pteval_t, 1) << 54) /* User XN */

I told you already ;), I'm not taking this patch. Some (of my) rules for
checkpatch usage:

1. Don't run it on existing code with the aim of fixing it
2. Existing coding style takes precedence over checkpatch warnings

(I have another rule but I don't want to impose it on anyone: I never
run checkpatch)

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/