linux-kernel - Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1509171217080.3951@nanos>
Date:	Thu, 17 Sep 2015 12:19:18 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
cc:	Caesar Wang <caesar.upstream@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Caesar Wang <wxt@...k-chips.com>,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability
 and compatible

On Thu, 17 Sep 2015, Daniel Lezcano wrote:
> On 09/17/2015 11:28 AM, Caesar Wang wrote:
> > > I think the NO_IRQ definition is missing for ARM64.
> > 
> > Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
> 
> Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
> 
> when there is an error it returns zero. So NO_IRQ and -1 are not correct and
> on the other side zero can be a valid irq. That sounds a little bit fuzzy to
> me.

IRQ0 is invalid for historical reasons. End of story.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/