lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Sep 2015 13:29:05 +0200
From: Maxime Ripard <maxime.ripard@...e-electrons.com>
To: yassinjaffer@...il.com
Cc: linux-sunxi@...glegroups.com, dmitry.torokhov@...il.com,
linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@...il.com wrote:
> From: Yassin Jaffer <yassinjaffer@...il.com>
>
> Add Keypad controller node definition to the A20 SoC.
>
> Signed-off-by: Yassin Jaffer <yassinjaffer@...il.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 333604a..35cc8d0 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1198,6 +1198,15 @@
> status = "disabled";
> };
>
> + kp: kp@...23000 {
The node name should reflect the class of the device. keypad@...23000
would be better for example.
It looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists