linux-kernel - Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150917122920.GA14933@goodgumbo.baconseed.org>
Date:	Thu, 17 Sep 2015 14:29:20 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	linux-kernel@...r.kernel.org
Cc:	Tejun Heo <tj@...nel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	linux-ide@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v3] ata: pata_macio: Fix module autoload for OF platform
 driver

On Thu, Sep 17, 2015 at 01:19:45PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> Link: https://lkml.org/lkml/2015/7/30/519
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> This fixes the typo error of version 2 reported by Stephen Rothwell
> https://lkml.org/lkml/2015/9/17/1
> 
>  drivers/ata/pata_macio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index b002858..e3d4b05 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -1344,6 +1344,7 @@ static struct of_device_id pata_macio_match[] =
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, pata_macio_match);
>  
>  static struct macio_driver pata_macio_driver =
>  {
> -- 
> 2.4.6
> 

Hi Tejun,

I sent this patch thinking that you would like to git revert the applied one
and git apply a correct one. To keep git bisect-ability.

You might want to apply a delta patch though. I could send that one, as you
prefer.

Thanks,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/