linux-kernel - Re: [PATCH v2 9/9] rtc: hym8563: make sure hym8563 can be normal work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55FAB5B6.3010605@rock-chips.com>
Date:	Thu, 17 Sep 2015 20:44:38 +0800
From:	Xing Zheng <zhengxing@...k-chips.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Heiko Stübner <heiko@...ech.de>,
	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 9/9] rtc: hym8563: make sure hym8563 can be normal
 work

On 2015年09月17日 20:31, Alexandre Belloni wrote:
> Hi,
>
> On 17/09/2015 at 14:07:47 +0200, Heiko Stübner wrote :
>> Am Donnerstag, 17. September 2015, 18:39:28 schrieb Xing Zheng:
>>> The rtc hym8563 maybe failed to register if first startup or rtc
>>> powerdown:
>>> [    0.988540 ] rtc-hym8563 1-0051: no valid clock/calendar values available
>>> [    0.995642 ] rtc-hym8563 1-0051: rtc core: registered hym8563 as rtc0 [
>>>    1.078985 ] rtc-hym8563 1-0051: no valid clock/calendar values available [
>>>     1.085698 ] rtc-hym8563 1-0051: hctosys: unable to read the hardware
>>> clock
>>>
>>> We can set initial time for rtc and register it:
>>> [    0.995678 ] rtc-hym8563 1-0051: rtc core: registered hym8563 as rtc0
>>> [    1.080313 ] rtc-hym8563 1-0051: setting system clock to 2000-01-01
>>> 00:02:00 UTC (946684920)
>> hmm, not setting a false date was actually intentional when I did the driver.
>>
>> In my mind it is better to shout and keep programs from using wrong values
>> than to set some arbitary date and let programs silently use this wrong value.
>>
> Indeed, I find it worse to set a wrong value instead of returning an
> error. Userspace has to define its policy when reading the time fails.
>
OK, I got it, this patch will be abandoned at next version.
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/