linux-kernel - Re: [PATCH] workqueue: Free useless memory when disabling NUMA in wq_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Sep 2015 11:29:51 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Xunlei Pang <xlpang@....com>
Cc:	linux-kernel@...r.kernel.org,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Xunlei Pang <pang.xunlei@....com.cn>
Subject: Re: [PATCH] workqueue: Free useless memory when disabling NUMA in
 wq_numa_init()

Hello,

On Thu, Sep 17, 2015 at 10:43:55AM +0800, Xunlei Pang wrote:
> From: Xunlei Pang <pang.xunlei@....com.cn>
> 
> wq_update_unbound_numa_attrs_buf and tbl will never be used
> in case of invalid NUMA node mapping, so just free them.
> 
> Signed-off-by: Xunlei Pang <pang.xunlei@....com.cn>
> ---
>  kernel/workqueue.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index ca71582..22d7747 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -5197,6 +5197,13 @@ static void __init wq_numa_init(void)
>  		node = cpu_to_node(cpu);
>  		if (WARN_ON(node == NUMA_NO_NODE)) {
>  			pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu);
> +
> +			for_each_node(node)
> +				free_cpumask_var(tbl[node]);
> +			kfree(tbl);

So, this is "either bios or arch code buggy but let's keep limping on
rather than crashing" path.  It doesn't matter whether there's
something lingering behind.  We wanna keep it as simple as possible.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/