linux-kernel - Re: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150917042507.GA16842@kroah.com>
Date:	Wed, 16 Sep 2015 21:25:07 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sakshi Vaid <sakshivaid95@...il.com>
Cc:	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	andreas.dilger@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared
 file_operations struct as const

On Wed, Sep 16, 2015 at 06:01:01PM +0530, Sakshi Vaid wrote:
> Declared the file_operations structure as const as done elsewhere in the
> kernel, as there are no modifiactions to this field.
> 
> Following warning found by checkpatch
> WARNING: struct file_operations should normally be const
> 
> Signed-off-by: Sakshi Vaid <sakshivaid95@...il.com>
> ---
>  drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> index c791941..c62c0ac 100644
> --- a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> +++ b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> @@ -146,7 +146,7 @@ static ssize_t mdc_kuc_write(struct file *file,
>  	return count;
>  }
>  
> -struct file_operations mdc_kuc_fops = {
> +const struct file_operations mdc_kuc_fops = {
>  	.open		= mdc_kuc_open,
>  	.write		= mdc_kuc_write,
>  	.release	= single_release,

This doesn't apply to my tree at all, what are you making it against?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/