linux-kernel - Re: [PATCH 03/13] Move COMPAT_ATM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55fb283c.f039440a.427ff.fffff187@mx.google.com>
Date:	Thu, 17 Sep 2015 13:53:16 -0700 (PDT)
From:	Palmer Dabbelt <palmer@...belt.com>
To:	dhowells@...hat.com
CC:	x86@...nel.org
Subject:     Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c

On Thu, 17 Sep 2015 02:57:12 PDT (-0700), dhowells@...hat.com wrote:
> Palmer Dabbelt <palmer@...belt.com> wrote:
>
>> +#ifdef CONFIG_COMPAT
>> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
>> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
>> +#endif
>
> I wonder if it would hurt to ditch the conditionals entirely.  It only eats
> cpp namespace, not C namespace so it won't affect the output if it is not used
> because the code that uses it is compiled out.

Makes sense to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/