linux-kernel - Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct helpers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150917.153208.217018898295996196.davem@davemloft.net>
Date:	Thu, 17 Sep 2015 15:32:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joestringer@...ira.com
Cc:	netdev@...r.kernel.org, pshelar@...ira.com,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH net] openvswitch: Fix IPv6 exthdr handling with ct
 helpers.

From: Joe Stringer <joestringer@...ira.com>
Date: Mon, 14 Sep 2015 11:14:50 -0700

> Static code analysis reveals the following bug:
> 
>         net/openvswitch/conntrack.c:281 ovs_ct_helper()
>         warn: unsigned 'protoff' is never less than zero.
> 
> This signedness bug breaks error handling for IPv6 extension headers when
> using conntrack helpers. Fix the error by using a local signed variable.
> 
> Fixes:  cae3a2627520: "openvswitch: Allow attaching helpers to ct
> action"
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Joe Stringer <joestringer@...ira.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/