linux-kernel - Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55FC15B9.9070407@atmel.com>
Date:	Fri, 18 Sep 2015 15:46:33 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Josh Wu <josh.wu@...el.com>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name

Le 10/09/2015 17:24, Alexandre Belloni a écrit :
> Hi,
> 
> On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
>> From: Josh Wu <josh.wu@...el.com>
>>
>> Correct the led labels in at91sam9n12ek.
>>
>> Signed-off-by: Josh Wu <josh.wu@...el.com>
>> ---
>>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index efa75064d38a..186a1705f8d3 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -204,13 +204,13 @@
>>  		};
>>  
>>  		d9 {
>> -			label = "d6";
>> +			label = "d9";
>>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>>  			linux,default-trigger = "nand-disk";
>>  		};
>>  
>>  		d10 {
>> -			label = "d7";
>> +			label = "d10";
>>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>>  			linux,default-trigger = "heartbeat";
>>  		};
> 
> The only concern being that this renaming will break userspace software
> assuming the LEDs are wrongly named. Is there anything that has been
> released by atmel that uses the wrong names (and my guess is yess and
> that is why there are named as such) and do you care about it?

My guess is that the label was wrongly named from the beginning and no
board revision had the "d6" nor "d7" names.
It makes sense to rename them for the evaluation kit...

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/