linux-kernel - Re: [PATCH] Staging: comedi: Fixed coding style issue in comedilib.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55FC22D3.1080006@mev.co.uk>
Date:	Fri, 18 Sep 2015 15:42:27 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Punit Vara <punitvara@...il.com>
CC:	gregkh@...il.com, hsweeten@...ionengravers.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fixed coding style issue in comedilib.h

On 18/09/15 15:34, Punit Vara wrote:
> This patch is to the comedilib.h file that fixes up coding style issues
> and following warning:
>
> - Block comments use * on subsequent lines
>
> Signed-off-by: Punit Vara <punitvara@...il.com>
> ---
>   drivers/staging/comedi/comedilib.h | 28 ++++++++++++++--------------
>   1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
> index 56baf85..45da22b 100644
> --- a/drivers/staging/comedi/comedilib.h
> +++ b/drivers/staging/comedi/comedilib.h
> @@ -1,20 +1,20 @@
> -/*
> -    linux/include/comedilib.h
> -    header file for kcomedilib
> +/**

Please use '/*' not '/**' here.

> + * linux/include/comedilib.h
> + * header file for kcomedilib
>
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 1998-2001 David A. Schleef <ds@...leef.org>
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1998-2001 David A. Schleef <ds@...leef.org>
>
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>
> -    This program is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -    GNU General Public License for more details.
> -*/
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Blank lines in the block comment should be ' *'.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/