linux-kernel - Re: [PATCH] powerpc: Kconfig: remove BE-only platforms from LE kernel build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150918002208.GB1300@fixme-laptop.cn.ibm.com>
Date:	Fri, 18 Sep 2015 08:22:08 +0800
From:	Boqun Feng <boqun.feng@...il.com>
To:	linuxppc-dev@...ts.ozlabs.org
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Olof Johansson <olof@...om.net>,
	Geoff Levand <geoff@...radead.org>
Subject: Re: [PATCH] powerpc: Kconfig: remove BE-only platforms from LE
 kernel build

Ping ;-)

Regards,
Boqun

On Mon, Sep 07, 2015 at 07:58:00AM +0800, Boqun Feng wrote:
> Currently, little endian is only supported on powernv and pseries,
> however, Kconfigs still allow us to include other platforms in a LE
> kernel, this may result in space wasting or even build error if some
> BE-only platforms always assume they are built for a BE kernel. So just
> modify the Kconfigs of BE-only platforms to remove them from being built
> for a LE kernel.
> 
> For 32bit only platforms, nothing needs to be done, because
> CPU_LITTLE_ENDIAN depends on PPC64. For 64bit supported platforms, add
> CPU_BIG_ENDIAN to dependencies explicitly, so that these platforms will
> be disabled for LE [Suggested-by: Cédric Le Goater <clg@...ibm.com>].
> 
> Signed-off-by: Boqun Feng <boqun.feng@...il.com>
> ---
>  arch/powerpc/platforms/cell/Kconfig     | 4 ++--
>  arch/powerpc/platforms/maple/Kconfig    | 2 +-
>  arch/powerpc/platforms/pasemi/Kconfig   | 2 +-
>  arch/powerpc/platforms/powermac/Kconfig | 2 +-
>  arch/powerpc/platforms/ps3/Kconfig      | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
> index 2f23133..808a904 100644
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -25,7 +25,7 @@ config PPC_CELL_NATIVE
>  
>  config PPC_IBM_CELL_BLADE
>  	bool "IBM Cell Blade"
> -	depends on PPC64 && PPC_BOOK3S
> +	depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
>  	select PPC_CELL_NATIVE
>  	select PPC_OF_PLATFORM_PCI
>  	select PCI
> @@ -35,7 +35,7 @@ config PPC_IBM_CELL_BLADE
>  
>  config PPC_CELL_QPACE
>  	bool "IBM Cell - QPACE"
> -	depends on PPC64 && PPC_BOOK3S
> +	depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
>  	select PPC_CELL_COMMON
>  
>  config AXON_MSI
> diff --git a/arch/powerpc/platforms/maple/Kconfig b/arch/powerpc/platforms/maple/Kconfig
> index 1ea621a..e359d0d 100644
> --- a/arch/powerpc/platforms/maple/Kconfig
> +++ b/arch/powerpc/platforms/maple/Kconfig
> @@ -1,5 +1,5 @@
>  config PPC_MAPLE
> -	depends on PPC64 && PPC_BOOK3S
> +	depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
>  	bool "Maple 970FX Evaluation Board"
>  	select PCI
>  	select MPIC
> diff --git a/arch/powerpc/platforms/pasemi/Kconfig b/arch/powerpc/platforms/pasemi/Kconfig
> index a2aeb32..00d4b28 100644
> --- a/arch/powerpc/platforms/pasemi/Kconfig
> +++ b/arch/powerpc/platforms/pasemi/Kconfig
> @@ -1,5 +1,5 @@
>  config PPC_PASEMI
> -	depends on PPC64 && PPC_BOOK3S
> +	depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
>  	bool "PA Semi SoC-based platforms"
>  	default n
>  	select MPIC
> diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig
> index 607124b..43c6062 100644
> --- a/arch/powerpc/platforms/powermac/Kconfig
> +++ b/arch/powerpc/platforms/powermac/Kconfig
> @@ -1,6 +1,6 @@
>  config PPC_PMAC
>  	bool "Apple PowerMac based machines"
> -	depends on PPC_BOOK3S
> +	depends on PPC_BOOK3S && CPU_BIG_ENDIAN
>  	select MPIC
>  	select PCI
>  	select PPC_INDIRECT_PCI if PPC32
> diff --git a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig
> index 56f2740..b27f40f 100644
> --- a/arch/powerpc/platforms/ps3/Kconfig
> +++ b/arch/powerpc/platforms/ps3/Kconfig
> @@ -1,6 +1,6 @@
>  config PPC_PS3
>  	bool "Sony PS3"
> -	depends on PPC64 && PPC_BOOK3S
> +	depends on PPC64 && PPC_BOOK3S && CPU_BIG_ENDIAN
>  	select PPC_CELL
>  	select USB_OHCI_LITTLE_ENDIAN
>  	select USB_OHCI_BIG_ENDIAN_MMIO
> -- 
> 2.5.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)