linux-kernel - Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Sep 2015 09:56:01 -0700
From:	Laura Abbott <labbott@...hat.com>
To:	Mathias Nyman <mathias.nyman@...el.com>,
	Laura Abbott <labbott@...oraproject.org>,
	Oliver Neukum <oneukum@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] Add spurious wakeup quirk for Lynxpoint controllers

On 09/18/2015 03:18 AM, Mathias Nyman wrote:
> On 10.09.2015 20:27, Laura Abbott wrote:
>>
>> We received several reports of systems rebooting and powering on
>> after an attempted shutdown. Testing showed that setting
>> XHCI_SPURIOUS_WAKEUP quirk in addition to the XHCI_SPURIOUS_REBOOT
>> quirk allowed the system to shutdown as expected for Lynxpoint
>> xHCI controllers. Set the qurik.
>>
>> Signed-off-by: Laura Abbott <labbott@...oraproject.org>
>> ---
>
> We used to have the XHCI_SPURIOUS_WAKEUP flag set for lynxpoint controllers,
> but it was removed in commit:
>
> commit b45abacde3d551c6696c6738bef4a1805d0bf27a
>      xhci: no switching back on non-ULT Haswell
>      The switch back is limited to ULT even on HP. The contrary
>      finding arose by bad luck in BIOS versions for testing.
>      This fixes spontaneous resume from S3 on some HP laptops.
>
> Adding the SPURIOUS_WAKEUP flag back looks reasonable to me,
> but I don't want to break suspend.
> I don't understand how it could have caused spontaneous resume in HP laptops
> in the first place, it really shouldn't do anything before shutdown.
>
> Better ask Oliver,
> Do you still have access to the HP laptop?
> Any chance you could see if the flag still causes spontaneous resume?
>
> -Mathias

Would you rather see a revert of the patch you gave rather than a new
one re-introducing the flag?

Thanks,
Laura
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/