linux-kernel - Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150918190912.GA1293@goodgumbo.baconseed.org>
Date:	Fri, 18 Sep 2015 21:09:12 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/4] usb: host: ehci-spear: Fix module autoload for OF
 platform driver

On Fri, Sep 18, 2015 at 02:57:10PM -0400, Alan Stern wrote:
> On Fri, 18 Sep 2015, Luis de Bethencourt wrote:
> 
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> > ---
> >  drivers/usb/host/ehci-spear.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> > index 34e1474..be7bcf2 100644
> > --- a/drivers/usb/host/ehci-spear.c
> > +++ b/drivers/usb/host/ehci-spear.c
> > @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
> >  	{ .compatible = "st,spear600-ehci", },
> >  	{ },
> >  };
> > +MODULE_DEVICE_TABLE(spear_ehci_id_table);
> 
> Shouldn't this be MODULE_DEVICE_TABLE(of, spear_ehci_id_table)?
> 
> Alan Stern
> 

Hi Alan,

Sorry about this. It looks like I accidentally sent a temporary version of
patch 1/4 and 3/4.

Sending the final and correct version now.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/