lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.1509181533190.1681-100000@iolanthe.rowland.org>
Date:	Fri, 18 Sep 2015 15:34:32 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Luis de Bethencourt <luis@...ethencourt.com>
cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] usb: host: ehci-spear: Fix module autoload for
 OF platform driver

On Fri, 18 Sep 2015, Luis de Bethencourt wrote:

> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>  drivers/usb/host/ehci-spear.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
> index 34e1474..3c4e525 100644
> --- a/drivers/usb/host/ehci-spear.c
> +++ b/drivers/usb/host/ehci-spear.c
> @@ -149,6 +149,7 @@ static const struct of_device_id spear_ehci_id_table[] = {
>  	{ .compatible = "st,spear600-ehci", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, spear_ehci_id_table);
>  
>  static struct platform_driver spear_ehci_hcd_driver = {
>  	.probe		= spear_ehci_hcd_drv_probe,
> 

Acked-by: Alan Stern <stern@...land.harvard.edu>

Also for V2 of patches 3/4 and 4/4.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ