linux-kernel - Re: [rtc-linux] [PATCH v3 1/2] Fixed ds1390_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150918220148.GH4287@piout.net>
Date:	Sat, 19 Sep 2015 00:01:48 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Ivan Grimaldi <grimaldi.ivan@...il.com>
Cc:	a.zummo@...ertech.it, mpfj@...c.co.uk, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] [PATCH v3 1/2] Fixed ds1390_get_reg returned value

Hi,

You've sent that series so many times that I'm not sure which one I
should look at...

Also, please include a changelog when submitting a new version of a
patch.

On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote :
> spi_write_then_read puts in rx_buf the received data starting from
> the first byte of the rx_buf
> 
> Signed-off-by: Ivan Grimaldi <grimaldi.ivan@...il.com>
> ---
>  drivers/rtc/rtc-ds1390.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
> index e67bfcb..a4303b4 100644
> --- a/drivers/rtc/rtc-ds1390.c
> +++ b/drivers/rtc/rtc-ds1390.c
> @@ -62,7 +62,7 @@ static int ds1390_get_reg(struct device *dev, unsigned char address,
>  	if (status != 0)
>  		return status;
>  
> -	*data = chip->txrx_buf[1];
> +	*data = chip->txrx_buf[0];
>  
>  	return 0;
>  }
> -- 
> 2.5.2
> 
> -- 
> -- 
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> --- 
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@...glegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/