linux-kernel - Re: [PATCH] staging: lustre: lustre: lclient: Removed the else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Sep 2015 19:44:26 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Anjali Menon <cse.anjalimenon@...il.com>
Cc:	oleg.drokin@...el.com, jinshan.xiong@...el.com,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: lustre: lclient: Removed the else
 statement

On Thu, Sep 17, 2015 at 09:44:41PM +0530, Anjali Menon wrote:
> Removed the else statement along with some unwanted brackets
> to fix the following coding style warning detected by
> checkpatch.
> 
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Anjali Menon <cse.anjalimenon@...il.com>
> ---
>  drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index ab6cb41..23092fc 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -836,7 +836,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
>  					*exceed = 1;
>  			}
>  			return result;
> -		} else {
> +		}
>  			/*
>  			 * region is within kms and, hence, within real file
>  			 * size (A). We need to increase i_size to cover the

This change isn't correct, look at how the code now looks :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/