linux-kernel - Re: [PATCH] Staging: android: Fix 80 character length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150919024050.GA21258@kroah.com>
Date:	Fri, 18 Sep 2015 19:40:50 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Punit Vara <punitvara@...il.com>
Cc:	devel@...verdev.osuosl.org, arve@...roid.com,
	riandrews@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 	Staging: android: Fix 80 character length

On Fri, Sep 18, 2015 at 02:24:16PM +0530, Punit Vara wrote:
> 	This patch is to the Kconfig file which fixes up lines which
> 	exceeded the standard  80 character limitation.
> 	This file also fixes up 3 warnings regarding paragraph.

Why is this indented?

> 
> Signed-off-by: Punit Vara <punitvara@...il.com>
> ---
>  drivers/staging/android/Kconfig | 28 ++++++++++++++++------------
>  1 file changed, 16 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 42b1512..f4a2371 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -12,7 +12,8 @@ config ASHMEM
>  	  file-based API.
>  
>  	  It is, in theory, a good memory allocator for low-memory devices,
> -	  because it can discard shared memory units when under memory pressure.

This is 80 characters wide, no need to change it.

> +	  because it can discard shared memory units when under memory
> +	  pressure.
>  
>  config ANDROID_TIMED_OUTPUT
>  	bool "Timed output class driver"
> @@ -24,19 +25,20 @@ config ANDROID_TIMED_GPIO
>  	depends on ANDROID_TIMED_OUTPUT
>  	default n
>          ---help---
> -	  Unlike generic gpio is to allow programs to access and manipulate gpio
> -	  registers from user space, timed output/gpio is a system to allow changing
> -	  a gpio pin and restore it automatically after a specified timeout.
> +	  Unlike generic gpio is to allow programs to access and manipulate
> +	  gpio registers from user space, timed output/gpio is a system to
> +	  allow changing a gpio pin and restore it automatically after a
> +	  specified timeout.
>  
>  config ANDROID_LOW_MEMORY_KILLER
>  	bool "Android Low Memory Killer"
>  	---help---
> -	  Registers processes to be killed when low memory conditions, this is useful
> -	  as there is no particular swap space on android.
> +	  Registers processes to be killed when low memory conditions, this
> +	  is useful as there is no particular swap space on android.
>  
> -	  The registered process will kills according to the priorities in android init
> -	  scripts (/init.rc), and it defines priority values with minimum free memory size
> -	  for each priority.
> +	  The registered process will kills according to the priorities in
> +	  android init scripts (/init.rc), and it defines priority values with
> +	  minimum free memory size for each priority.
>  
>  config SYNC
>  	bool "Synchronization framework"
> @@ -44,8 +46,9 @@ config SYNC
>  	select ANON_INODES
>  	select DMA_SHARED_BUFFER
>  	---help---
> -	  This option enables the framework for synchronization between multiple

This is also ok.


> -	  drivers.  Sync implementations can take advantage of hardware
> +	  This option enables the framework for synchronization between
> +	  multiple drivers.
> +	  Sync implementations can take advantage of hardware
>  	  synchronization built into devices like GPUs.
>  
>  config SW_SYNC
> @@ -54,7 +57,8 @@ config SW_SYNC
>  	depends on SYNC
>  	---help---
>  	  A sync object driver that uses a 32bit counter to coordinate
> -	  synchronization.  Useful when there is no hardware primitive backing

And this is just fine, why change it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/