linux-kernel - Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150919100622.GJ3218@x1>
Date:	Sat, 19 Sep 2015 11:06:22 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Cc:	Milo Kim <milo.kim@...com>, Jingoo Han <jingoohan1@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Werner Johansson <werner.johansson@...ymobile.com>
Subject: Re: [PATCH] backlight: lp855x: Make sure props struct is zeroed

On Thu, 27 Aug 2015, Bjorn Andersson wrote:

> From: Werner Johansson <werner.johansson@...ymobile.com>
> 
> The driver occasionally got stuck in suspend mode or other strange
> states as those parts of the props struct were never initialized.
> 
> Signed-off-by: Werner Johansson <werner.johansson@...ymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>
> ---
>  drivers/video/backlight/lp855x_bl.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index 88116b493f3b..0a7f88ce1ab0 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -282,6 +282,7 @@ static int lp855x_backlight_register(struct lp855x *lp)
>  	struct lp855x_platform_data *pdata = lp->pdata;
>  	const char *name = pdata->name ? : DEFAULT_BL_NAME;
>  
> +	memset(&props, 0, sizeof(props));
>  	props.type = BACKLIGHT_PLATFORM;
>  	props.max_brightness = MAX_BRIGHTNESS;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/