linux-kernel - Re: spi-imx: wait_for_completion should timeout even in non-DMA transfer cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150919175614.GM30445@sirena.org.uk>
Date:	Sat, 19 Sep 2015 10:56:14 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Michel Hautbois <jean-michel.hautbois@...-labs.com>
Cc:	linux-spi@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: spi-imx: wait_for_completion should timeout even in non-DMA
 transfer cases

On Fri, Sep 18, 2015 at 02:38:27PM +0200, Jean-Michel Hautbois wrote:
> Hi,
> 
> I am wondering why in spi-imx the spi_imx_pio_transfer() function is
> calling wait_for_completion() and not wait_for_completion_timeout() as
> in the spi_imx_dma_transfer() one.
> I can't see a good reason for this, maybe should it be calculated
> based on the spi clock and transfer->len, or at least be the same as
> IMX_DMA_TIMEOUT which is 3 seconds ?
> If you want it, I have a patch, just tell me if you are interested and
> if you prefer a calculated timeout or even something else ?

A calculated timeout is probably best.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)