linux-kernel - Re: [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55FE8C3B.605@kernel.org>
Date:	Sun, 20 Sep 2015 11:36:43 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	linux-kernel@...r.kernel.org
Cc:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Axel Lin <axel.lin@...ics.com>, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF
 platform driver

On 17/09/15 18:02, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
Applied to the togreg branch of iio.git as I am treating these
as additions of functionality rather than explicit fixes.
I am guessing previous users didn't care about autoprobing
(and a lot of embedded systems don't use it).  Hence it
can wait for the next merge window.

Thanks for clearing these up,

Jonathan
> ---
>  drivers/iio/adc/twl6030-gpadc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index df12c57..becbb0a 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -875,6 +875,7 @@ static const struct of_device_id of_twl6030_match_tbl[] = {
>  	},
>  	{ /* end */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_twl6030_match_tbl);
>  
>  static int twl6030_gpadc_probe(struct platform_device *pdev)
>  {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/