[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAALWOA_=hs+Xa2f+3=s=QaxA9HfVfHJnW0dzK6toRcFFiOvdTA@mail.gmail.com>
Date: Sun, 20 Sep 2015 12:38:44 +0200
From: Matthijs van Duin <matthijsvanduin@...il.com>
To: Lokesh Vutla <lokeshvutla@...com>
Cc: herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
davem@...emloft.net,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
lkml <linux-kernel@...r.kernel.org>,
Tero Kristo <t-kristo@...com>, nsekhar@...com
Subject: Re: [PATCH v3] crypto: omap-aes: Add support for GCM mode
On 15 September 2015 at 15:28, Lokesh Vutla <lokeshvutla@...com> wrote:
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -293,6 +293,7 @@ config CRYPTO_DEV_OMAP_AES
> depends on ARCH_OMAP2 || ARCH_OMAP3 || ARCH_OMAP2PLUS
> select CRYPTO_AES
> select CRYPTO_BLKCIPHER
> + select CRYPTO_AEAD
Is it appropriate that this also selects CRYPTO_AEAD on omap2/omap3,
even though they do not support GCM?
> +#define AES_REG_CTRL_GCM GENMASK(17, 16)
Instead of adding these definitions one bit at a time, can't we get
the whole list over with at once? This thing supports:
ECB, CBC, and CFB-128 encryption
CTR and F8 encryption with 16/32/64/96/128-bit counter
XEX (disk encryption)
CBC-MAC authentication including the CMAC/OMAC/PMAC subflavors
F9 authentication
GCM and CCM aead
(and raw GHASH, if you happen to have a use for it)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists