linux-kernel - Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150921083345.GE20113@pali>
Date:	Mon, 21 Sep 2015 10:33:45 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	"Andrew F. Davis" <afd@...com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Dan Murphy <dmurphy@...com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c
 MODULE_ALIAS

On Monday 14 September 2015 16:26:07 Andrew F. Davis wrote:
> The MODULE_DEVICE_TABLE macro automatically adds all needed
> i2c MODULE_ALIASes so remove the extra MODULE_ALIAS.
> 
> Signed-off-by: Andrew F. Davis <afd@...com>

Acked-by: Pali Rohár <pali.rohar@...il.com>

> ---
>  drivers/power/bq27x00_battery.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index 8287261f..d0b2f3b 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -1120,10 +1120,6 @@ module_exit(bq27x00_battery_exit);
>  MODULE_ALIAS("platform:bq27000-battery");
>  #endif
>  
> -#ifdef CONFIG_BATTERY_BQ27X00_I2C
> -MODULE_ALIAS("i2c:bq27000-battery");
> -#endif
> -
>  MODULE_AUTHOR("Rodolfo Giometti <giometti@...ux.it>");
>  MODULE_DESCRIPTION("BQ27x00 battery monitor driver");
>  MODULE_LICENSE("GPL");

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/