linux-kernel - Re: [alsa-devel] [PATCH RFC 1/7] ASoC: tlv320aic26: Add device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55FFC204.9000903@ti.com>
Date:	Mon, 21 Sep 2015 11:38:28 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	"Cormier, Jonathan" <jcormier@...ticallink.com>,
	Liam Girdwood <lgirdwood@...il.com>
CC:	<alsa-devel@...a-project.org>, Bob Duke <bduke@...ticallink.com>,
	Mark Brown <broonie@...aro.org>,
	<linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.com>,
	Jyri Sarha <jsarha@...com>,
	Mike Williamson <michael.williamson@...ticallink.com>,
	Greg Gluszek <greg.gluszek@...ticallink.com>,
	Misael Lopez Cruz <misael.lopez@...com>
Subject: Re: [alsa-devel] [PATCH RFC 1/7] ASoC: tlv320aic26: Add device tree
 binding

On 09/18/2015 11:11 PM, Cormier, Jonathan wrote:

> diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
> index 620ab9ea1ef0..91fdd96648bd 100644
> --- a/sound/soc/codecs/tlv320aic26.c
> +++ b/sound/soc/codecs/tlv320aic26.c
> @@ -370,10 +370,20 @@ static int aic26_spi_remove(struct spi_device *spi)
>  	return 0;
>  }
>  
> +#if defined(CONFIG_OF)

You don't need the #ifdef here

> +static const struct of_device_id tlv320aic26_of_match[] = {
> +	{ .compatible = "ti,tlv320aic26", },
> +	{},
> +};
> +#endif
> +
>  static struct spi_driver aic26_spi = {
>  	.driver = {
>  		.name = "tlv320aic26-codec",
>  		.owner = THIS_MODULE,
> +#if defined(CONFIG_OF)

neither here.

> +		.of_match_table = of_match_ptr(tlv320aic26_of_match),
> +#endif
>  	},
>  	.probe = aic26_spi_probe,
>  	.remove = aic26_spi_remove,
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/