linux-kernel - Re: [PATCH v2 5/8] lib: introduce sg_nents_len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Sep 2015 22:19:17 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Tony Battersby <tonyb@...ernetics.com>
Cc:	LABBE Corentin <clabbe.montjoie@...il.com>, davem@...emloft.net,
	akpm@...ux-foundation.org, arnd@...db.de, axboe@...com,
	david.s.gordon@...el.com, martin.petersen@...cle.com,
	robert.jarzmik@...e.fr, thomas.lendacky@....com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	lee.nipper@...il.com, yuan.j.kang@...il.com
Subject: Re: [PATCH v2 5/8] lib: introduce sg_nents_len_chained

On Fri, Sep 18, 2015 at 05:25:47PM -0400, Tony Battersby wrote:
>
> So instead of adding a new function sg_nents_len_chained(), a better
> cleanup would be:
> 1) replace the driver-specific functions with calls to sg_nents_for_len()
> 2) get rid of the "chained" variables
> 3) always call dma_map_sg()/dma_unmap_sg() for the entire scatterlist
> regardless of whether or not the scatterlist is chained
> 
> Would someone more familiar with the crypto API please confirm that my
> suggestions are correct?

Yes I think you're absolutely right Tony.  Corentin, could you
please take this opportunity to clean up those drivers so that
they simply use dma_map_sg a single time rather than over and
over again for chained SG lists?

You only have to redo patches 5-8.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/