linux-kernel - Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for nx842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150921142607.GA2405@gondor.apana.org.au>
Date:	Mon, 21 Sep 2015 22:26:07 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Haren Myneni <haren@...ux.vnet.ibm.com>
Cc:	davem@...emloft.net, ddstreet@...e.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	hbabu@...ibm.com
Subject: Re: [PATCH] drivers/crypto/nx: Add CRC and validation support for
 nx842

On Sat, Sep 19, 2015 at 05:02:42PM -0700, Haren Myneni wrote:
> Hi, 
> 
> This patch allows nx842 coprocessor to add CRC for compression and
> check the computed CRC value for uncompression. Please let me know 
> if you have any comments.
> 
> Thanks
> Haren
> 
> commit d0b34d2e3ed41e7ec2afdbd654f0dd7716e4d4c0
> Author: Haren Myneni <haren@...ibm.com>
> Date:   Sat Sep 12 01:20:51 2015 -0700
> 
>     crypto/nx842: Add CRC and validation support
>     
>     This patch adds CRC generation and validation support for nx-842. 
>     Add CRC flag so that nx842 coprocessor includes CRC during 
>     compression and validates during uncompression. 
>     
>     Signed-off-by: Haren Myneni <haren@...ibm.com>

In future please post the patch without all the metadata.  You
can use the helper git format-patch to help you prepare the patch
for submission.

As to the CRC itself what is the purpose of this and wouldn't it
fail our test vectors if we had any? Remember that we also have a
software implementation now and the hardware should produce exactly
the same output as the software version.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/