linux-kernel - Re: [RFC PATCH 0/3] fix *pbl format support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fv27lp02.fsf@rasmusvillemoes.dk>
Date:	Mon, 21 Sep 2015 18:24:13 +0200
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Maurizio Lombardi <mlombard@...hat.com>
Cc:	Tejun Heo <tj@...nel.org>, joe@...ches.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	dgilbert@...erlog.com
Subject: Re: [RFC PATCH 0/3] fix *pbl format support

On Mon, Sep 21 2015, Maurizio Lombardi <mlombard@...hat.com> wrote:

> Hi Rasmus,
>
> On 09/16/2015 10:35 PM, Rasmus Villemoes wrote:
>> 
>> I just remembered: I noticed a while ago that the qualifier member is
>> only used inside format_decode (in the end, the information is folded
>> into the type member), so one might as well use a local variable for
>> that. This gives option (3): Make field_width a 24 bit bitfield. I think
>> that should be sufficient for any realistic bitmap that one would
>> print. The patch is also rather small. Surprisingly, bloat-o-meter even
>> says that it's also a net win in code size:
>
> I tested your patch with scsi-debug and it works for me:

Thanks for testing it! What do people think of this option?

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/