linux-kernel - Re: Possible Bug in move_encrypted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150921185122.GD20551@jaegeuk-mac02.mot.com>
Date:	Mon, 21 Sep 2015 11:51:22 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	nick <xerofoify@...il.com>
Cc:	cm224.lee@...sung.com, chao2.yu@...sung.com,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: Possible Bug in move_encrypted_block

Hi,

On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote:
> Greetings Jaeguek and others.
> Below are the lines fora possible bug in  move_encrypted_block:
> err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
>         if (err)
>                 goto out;
> Also calls of get_dnode_of_data need to hold the semaphone for the superblock
> this call is being done on to avoid concurrent access on data being received

IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this?
To be honest, I can't catch your point.

Thanks,

> here from the superblock and file system on disk. In addition unless I get a
> reply to this I will not be sending in a bug fix for this.
> Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/