linux-kernel - Re: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150921190251.GE13263@mtj.duckdns.org>
Date:	Mon, 21 Sep 2015 15:02:51 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata:Check if D2H Register FIS command fails in the
 function ahci_do_softreset

On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote:
> This fixes the missing error check and handling if the second D2H
> register command fails in the function fails.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

This isn't exactly a command execution and the success condition
checks are performed manually afterwards.  The ignoring of command
execution result is intentional there and the proposed change is
likely to cause more harm than good.  Unless there are specific cases
where the new code would behave better, I'd much rather leave it as it
is.

Thansk.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/