linux-kernel - Re: [PATCH] ata:Fix error handling in the function ahci_pci_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150921190754.GF13263@mtj.duckdns.org>
Date:	Mon, 21 Sep 2015 15:07:54 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata:Fix error handling in the function
 ahci_pci_reset_controller

On Fri, Sep 18, 2015 at 11:27:47PM -0400, Nicholas Krause wrote:
> This fixes error handling in the function ahci_pci_reset_controller
> to properly check if the call to ahci_reset_controller fails and
> if return -EIO to this function's caller rather then continuing
> with this function's intended work if the controller cannot be
> reset properly for this ahci pci based device.

Maybe... I don't know.  What do we gain by failing resume?  Reporting
is fine but what'd be the recovery action?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/