linux-kernel - Re: [PATCH 33/38] mm/memblock.c: remove invalid check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150921143101.09426cd661fe66e65a1c06b5@linux-foundation.org>
Date:	Mon, 21 Sep 2015 14:31:01 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	linux-kernel@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Alexander Kuleshov <kuleshovmail@...il.com>,
	Tony Luck <tony.luck@...el.com>,
	Wei Yang <weiyang@...ux.vnet.ibm.com>, linux-mm@...ck.org
Subject: Re: [PATCH 33/38] mm/memblock.c: remove invalid check

On Mon, 21 Sep 2015 15:34:05 +0200 Andrzej Hajda <a.hajda@...sung.com> wrote:

> Unsigned value cannot be lesser than zero.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
> 
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -837,7 +837,7 @@ void __init_memblock __next_reserved_mem_region(u64 *idx,
>  {
>  	struct memblock_type *type = &memblock.reserved;
>  
> -	if (*idx >= 0 && *idx < type->cnt) {
> +	if (*idx < type->cnt) {

Linus has in the past expressed a preference for retaining checks such
as this.  iirc he finds it clearer.  And perhaps safer if the type
should change in the future.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/