linux-kernel - Re: [PATCH 4/4] sound/core/seq: make prioq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1442928492.2018.9.camel@sipsolutions.net>
Date:	Tue, 22 Sep 2015 15:28:12 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Yaowei Bai <bywxiaobai@....com>
Cc:	perex@...ex.cz, tiwai@...e.com, k.kozlowski@...sung.com,
	elfring@...rs.sourceforge.net, fabf@...net.be, lars@...afoo.de,
	linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool

On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote:
> On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote:
> > 
> > > -static inline int prioq_match(struct snd_seq_event_cell *cell,
> > > +static inline bool prioq_match(struct snd_seq_event_cell *cell,
> > >  			      int client, int timestamp)
> > 
> > I think you should fix up the indentation now.
> 
> Sorry, I'm quite a new guy to linux kernel. I think you mean this 
> patch is not appropriate, right?
> 

No, the change itself is fine, but you should fix the indentation there
so it lines up properly after your change.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/