linux-kernel - Re: [PATCH 3/3] power: reset: at91-shdwc: add new shutdown controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150922135925.GI23334@earth>
Date:	Tue, 22 Sep 2015 15:59:25 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	linux@...ck-us.net,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Subject: Re: [PATCH 3/3] power: reset: at91-shdwc: add new shutdown
 controller driver

Hi,

On Thu, Sep 10, 2015 at 12:39:18PM +0200, Nicolas Ferre wrote:
> Sama5d2 SoC has a completely new shutdown controller with new
> features and register layout. It thus makes sense to add a new
> driver for this new peripheral.
> 
> This driver is Device Tree only and handles events from the
> wake-up pin and the RTC. As the register layout may change in the
> future, so some values are encoded in a configuration structure.
>
> [...]
>
> +static struct of_device_id at91_shdwc_of_match[] = {
> +	{
> +		.compatible = "atmel,sama5d2-shdwc",
> +                .data = &sama5d2_shdwc_config,
> +	}, {
> +		/*sentinel*/
> +	}
> +};

please add:

MODULE_DEVICE_TABLE(of, at91_shdwc_of_match);

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)