linux-kernel - Re: [PATCH] x86/mm: Export cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Sep 2015 11:53:03 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	James Forcier <csssuf@...suf.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
	"Juergen Gross <jgross@...e.com, Toshi Kani" <toshi.kani@...com>,
	Jan Beulich <JBeulich@...e.com>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol

On Tue, Sep 22, 2015 at 11:51 AM, James Forcier <csssuf@...suf.net> wrote:
> Exporting cpu_tlbstate as a GPL symbol was introduced in 1e02ce4c; however, this
> breaks non-GPL modules which need to link against it, particularly the AMD
> Catalyst drivers.

What is AMD Catalyst doing with cpu_tlbstate?

--Andy

>
> Signed-off-by: James Forcier <csssuf@...suf.net>
> ---
>  arch/x86/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index 1d8a83d..94be56b 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -742,7 +742,7 @@ DEFINE_PER_CPU_SHARED_ALIGNED(struct tlb_state, cpu_tlbstate) = {
>  #endif
>         .cr4 = ~0UL,    /* fail hard if we screw up cr4 shadow initialization */
>  };
> -EXPORT_SYMBOL_GPL(cpu_tlbstate);
> +EXPORT_SYMBOL(cpu_tlbstate);
>
>  void update_cache_mode_entry(unsigned entry, enum page_cache_mode cache)
>  {
> --
> 2.4.6
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/